Skip to content

GH-48811: [C++][FlightRPC] ODBC: Add missing arrow:: to fix build #48810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kou merged 1 commit into from
Jan 10, 2026
Merged

GH-48811: [C++][FlightRPC] ODBC: Add missing arrow:: to fix build #48810

kou merged 1 commit into from
Jan 10, 2026
+2 −2

Conversation

@alinaliBQ
Copy link
Collaborator

@alinaliBQ alinaliBQ commented Jan 10, 2026 •
edited by github-actions bot
Loading

Rationale for this change

Add arrow:: to Decimal128Type::kMaxPrecision to fix the build

What changes are included in this PR?

  • Add arrow:: as prefix to Decimal128Type::kMaxPrecision

Are these changes tested?

  • Yes, on local MSVC and CI

Are there any user-facing changes?

N/A

@alinaliBQ alinaliBQ added the CI: Extra: C++ Run extra C++ CI label Jan 10, 2026
@alinaliBQ alinaliBQ marked this pull request as ready for review January 10, 2026 00:24
@alinaliBQ alinaliBQ requested a review from lidavidm as a code owner January 10, 2026 00:24
@alinaliBQ
Copy link
Collaborator Author

alinaliBQ commented Jan 10, 2026 •
edited
Loading

Hi @lidavidm could you take a look at this minor PR? Thanks! cc @HyukjinKwon

HyukjinKwon
HyukjinKwon approved these changes Jan 10, 2026
View reviewed changes
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for catching this. I think I shouldn't touch this code path till my env is fully ready 😅

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Jan 10, 2026
@HyukjinKwon
Copy link
Member

HyukjinKwon commented Jan 10, 2026

Oh BTW I believe this needs a ticket instead of marking it a minor

@alinaliBQ alinaliBQ changed the title MINOR: [C++][FlightRPC] ODBC: Add missing arrow:: to fix build GH-48811: [C++][FlightRPC] ODBC: Add missing arrow:: to fix build Jan 10, 2026
@github-actions
Copy link

github-actions bot commented Jan 10, 2026

⚠️ GitHub issue #48811 has been automatically assigned in GitHub to PR creator.

@alinaliBQ
Copy link
Collaborator Author

alinaliBQ commented Jan 10, 2026

Oh BTW I believe this needs a ticket instead of marking it a minor

Thanks for the reminder, I have raise an issue #48811 😄

@alinaliBQ
Copy link
Collaborator Author

alinaliBQ commented Jan 10, 2026

LGTM thanks for catching this. I think I shouldn't touch this code path till my env is fully ready 😅

No worries! Ty for taking a look

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jan 10, 2026
kou
kou approved these changes Jan 10, 2026
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 6c7de4e into apache:main Jan 10, 2026
60 of 70 checks passed
@kou kou removed the awaiting merge Awaiting merge label Jan 10, 2026
@kou kou mentioned this pull request Jan 10, 2026
Closed
@github-actions github-actions bot added the awaiting merge Awaiting merge label Jan 10, 2026
@conbench-apache-arrow
Copy link

conbench-apache-arrow bot commented Jan 10, 2026

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 6c7de4e.

There weren't enough matching historic benchmark results to make a call on whether there were regressions.

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou kou approved these changes

@lidavidm lidavidm lidavidm approved these changes

+1 more reviewer

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting merge Awaiting merge CI: Extra: C++ Run extra C++ CI Component: C++ Component: FlightRPC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alinaliBQ @HyukjinKwon @kou @lidavidm